Clicking Get IMAGE rendering button on map triggers map popup

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code

Other

2 stars 0 forks source link

Clicking Get IMAGE rendering button on map triggers map popup #299

Closed jeffbl closed 1 month ago

jeffbl commented 1 year ago

Brave on Linux Production extension 0.4.7 installed from chrome web store

Go to this map: https://www.tripadvisor.com/Restaurant_Review-g34438-d23806008-Reviews-Mayami_Wynwood-Miami_Florida.html

Click the Get IMAGE rendering button NOTE: triggers getting IMAGE renderings (correct) NOTE: Also pops up expanded map (unexpected)

I'd be concerned that the user will lose context, since they probably won't expect that the website will change just based on clicking the IMAGE button.

jeffbl commented 4 months ago

For me on Brave, the button no longer appears at all! Should it be appearing, or was this removed as part of another fix? Not sure if this still happens if button is present?

jaydeepsingh25 commented 1 month ago

I believe this is working as expected. The button does not appear because maps on this website are not embedded in a conventional manner. Maps on this website are inside a button, and on click of a button - it opens a popup window. Not sure if we really need to handle such a scenario in the extension. Closing this issue for now. @jeffbl please feel free to reopen this incase you feel that it is important to fix this issue.

jeffbl commented 3 weeks ago

OK, since the button shouldn't be there, we can live with the other weirdnesses. If we see the same thing when the button should appear, then we'll have to bring this back.