Closed emmanuelwilson closed 1 year ago
Triaging production issue since either it is already there (maybe introduced with Manifest v3 changes?) or it will be soon be once we deploy.
Just reproduced on current production build against pegasus, Brave on Lilnux. Left IMAGE homepage up and unused for a long time (about an hour), tried right clicking photo and getting IMAGE rendering. No popup, no results. After page refresh, works fine.
Service workers were designed to timeout after 5 mins of idle activity . This seems to have been fixed by google in their latest chrome update. https://developer.chrome.com/blog/longer-esw-lifetimes/
@jeffbl / @emmanuelwilson can you please try using a latest version of chrome with test extension. I am using chrome version Version 111.0.5563.65 (Official Build) (64-bit)
on windows, and it is not giving any timeout for me. Please let me know if it does not work for you even after getting the latest update.
Still not sure if this will solve issue with brave on Linux!!
With the same version of Chrome 111.0.5563.65
on windows and version 0.4.9I
of the IMAGE test extension I no longer see this issue!
Brave on linux is only at Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
so I'll have to wait to test. Same version shows up for me in Chrome on linux, so can't test there either yet. If you want to close now since it is fixed on major platform(s), that is ok with me. I'll reactivate into backlog if turns out fix does not take effect on linux/brave soon, but if it is only that platform, it would be low priority.
More testing indicates this issue still exists on different platforms:
Test extension Chrome Windows @emmanuelwilson Test/Production extension Vivaldi Windows @Cybernide Test extension Chrome Ubuntu @jeffbl Production extension Brave Ubuntu @jeffbl
I managed to recreate the issue on Arch Linux
It takes around 3m40s to 4 minutes of idling (from the previous request) for the issue to occur.
More testing indicates this issue still exists on different platforms:
Test extension Chrome Windows @emmanuelwilson Test/Production extension Vivaldi Windows @Cybernide Test extension Chrome Ubuntu @jeffbl Production extension Brave Ubuntu @jeffbl
FYI I'm using Opera, Antoine's using Vivaldi
The PR above should fix this issue. @jeffbl Can we close this after a round of testing on nightly extension?
Just tested nightly extension in Chrome on Ubuntu. Waited over 3 minutes, and still worked. Waited another 9 minutes with tabs idle, and both still worked. Seems good on my end!
Testing the extension on idle tabs after 1,2,3 and 4 mins, I found that the extension does not respond after 4 mins of a tab being idle. I am using: