Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Promote Haply 2diy options out of developer mode? #353

Open jeffbl opened 1 year ago

jeffbl commented 1 year ago

Haply options were put in the developer section to hide them away since we figured most people do not have a haply, and it was pretty much always experimental. However, if we are going to be shipping experiences for the Haply, this isn't really a developer-only thing at that point.

QUESTION: How should we hide/expose the Haply functionality? From what I know of how this works, I'd propose something like:

New "Haptic Hardware" section of options, above Developer options toggle If the browser doesn't support WebSerial, under it just put something like "This browser does not support WebSerial, so cannot connect to a Haptic device." If the browser does support WebSerial, show the current radio buttons for None / Haply 2diy2g / Haply 2diy3g

However, nobody but us will ever have a 2diy2g. Not sure how much to complicate this further, but at some point, that option should be removed. Ideally, the extension would be able to query the device version and automatically load the correct parameters, in which case it could just have None / Haply 2diy, then automatically figure out the correct parameters to load.

Putting in October 02 sprint to get this discussion rolling, as I don't want to leave this to the end, especially due to ongoing issues with the fragile options code.

Cybernide commented 11 months ago

So if we want to move the 2diy out of Developer Mode, then we don't need to specify. "Haply 2diy" is likely to suffice.

If we cannot query the device version, a radio button labeled "Haply 2diy2g" can remain inside the developer options, since only our team is likely to know which version of the device we're dealing with.

Shall I wireframe?

jeffbl commented 11 months ago

@Cybernide When ready, please make sure to assign to @jaydeepsingh25, and I'll move this into Jaydeep's queue depending on his load when the design is complete.

jeffbl commented 11 months ago

Moving forward two sprints in anticipation of wireframes and assignment to jaydeep, who is unlikely to get to implementation in current sprint.

Cybernide commented 11 months ago

Wireframe here

As usual, upload to wireframing tool mydraft.cc

Assigning to @jaydeepsingh25 also please let me know if I've overlooked anything or if you need clarification

jeffbl commented 9 months ago

@jaydeepsingh25 possible to do this before holiday, while still prioritizing the full in-extension 2diy experience? If not, let me know and I'll move to January, but even as we test the 2diy code internally, would be good to also be testing the UI to enable it that we expect actual users to interact with. (Moving to Dec21)

jaydeepsingh25 commented 9 months ago

@Cybernide looks like the wireframe link above (https://github.com/Shared-Reality-Lab/IMAGE-browser/issues/ui-wireframes-mockups/UI_Options_2diy.json) is invalid, Can you please provide wireframes to implement this work-item?