search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

fix: renderings title #356

Closed jaydeepsingh25 closed 1 year ago

jaydeepsingh25 commented 1 year ago

resolves https://github.com/Shared-Reality-Lab/IMAGE-browser/issues/348.

jaydeepsingh25 commented 1 year ago

@jeffbl / @Cybernide Can you please review the french translation of the title? I added the translation as suggested by Google. Not sure if it is correct.

Cybernide commented 1 year ago

I would say 'yes' it's grammatical, but I'm giving this to @JRegimbal and @emmanuelwilson because I'm not certain if this follows convention in so far as UI elements go.

emmanuelwilson commented 1 year ago

The very last one is still in English, I don't know if that was intentional or not. Giving a quick read over and I think it looks good! I am personally not a fan of the use of "Rendu" for rendering as it doesn't feel right but I don't have any better suggestions. I will ask one of our other french members and get back to you guys! I would want to suggest "interpretation" instead but that isn't precisely the right word. It is also possible that I am just not used to "rendu" being used in this context.

JRegimbal commented 1 year ago

It seems « rendu » would be the preferred translation, at least it is for the OQLF. That being said, I thought we were moving away from showing "rendering" to the user in the extension, preferring either "representation" or "interpretation"? We do use this terminology inconsistently though (e.g., interpretation/interprétation for the labels but then full rendering/rendu complet in segmented audio).

tl;dr I think the translation is probably fine, but the title may not be following our own conventions in both cases.

jeffbl commented 1 year ago

Assigned to @Cybernide for wording heads-up/decision.

Cybernide commented 1 year ago

I say go ahead with the merge but then we should make a work item to ensure consistency in our terminology at a later date. What say you, @jeffbl ?

jeffbl commented 1 year ago

@Cybernide Sorry, was not assigned to me and missed notification on this. If something is blocked on me, please assign to me. Would rather just do it all in one shot if not too much effort to sync up language to be consistent within and across languages, but if that will take significant time, ok with doing this as first step. Just make sure to log the new work item and link it here.