search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Adds a way to download xcode workspace file automated via Github Actions #368

Closed 21satvik closed 6 months ago

jeffbl commented 6 months ago

Just one comment above, but assigning to @jaydeepsingh25 for full review/merge. Thanks for automating this @21satvik! @jaydeepsingh25 - the goal here is to have the safari version built, and have a xcode workspace all set so that

  1. If we change anything that causes the safari build to fail, it is immediately obvious and can be fixed as soon as the change is merged
  2. If someone wants to run it, they have an xcode workspace all set to start with
jaydeepsingh25 commented 6 months ago

I don't think you can reuse the existing workflow, you need different runners for these two scenarios. One needs macos while other needs Ubuntu. Also the artifact which is uploaded has the following files. @21satvik can you please confirm if all these files files are required to run XCode project? image

21satvik commented 6 months ago

I don't think you can reuse the existing workflow, you need different runners for these two scenarios. One needs macos while other needs Ubuntu. Also the artifact which is uploaded has the following files. @21satvik can you please confirm if all these files files are required to run XCode project? image

@jaydeepsingh25 Yes, all these files are for the different targets that show up when you open the workspace file in Xcode.