Developer mode switch in options no longer works

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code

Other

2 stars 0 forks source link

Developer mode switch in options no longer works #385

Closed jeffbl closed 2 months ago

jeffbl commented 3 months ago

Install test or production extension Brave, Chromium, Chrome browser all exhibit issue Go to extension options Enable developer mode switch Save Confirm save Go to image.a11y.mcgill.ca right click a photo Note: "Get IMAGE rendering" with no submenu Expect: submenu with debug options

jeffbl commented 3 months ago

Triaged user impact production issue since we have potential partners who are unable to use this to evaluate IMAGE, and are awaiting the fix.

jaydeepsingh25 commented 3 months ago

Issue was introduced as a regression with the PR. Fix has been provided in https://github.com/Shared-Reality-Lab/IMAGE-browser/commit/b74977b7ec2aaa12fd6419ea5fc00e7dd525de24 . Tested both the issues, developer mode switch and change in browser locale-Working fine. Assigning to @jeffbl for another round of testing on Nightly build

jeffbl commented 3 months ago

Working for me now in test version of extension. If nothing else found by others before sprint meeting tomorrow, let's work to get this released and closed.

Cybernide commented 3 months ago

The context menu items appear when a local graphic is uploaded to the UI and the user right-clicks on it. However, the context menu items are unresponsive here. Expect: Clicking on submenu items in the IMAGE context menu when a local graphic is uploaded to the UI will either produce an IMAGE rendering, allow a user to save the preprocessor data, or allow a user to save the request data. Actual: Clicking on any submenu item elicits no action from the extension.

Related images: