search

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code
Other
2 stars 0 forks source link

Wikipedia "You need to attribute the author" popup interferes with IMAGE context menu functionality #53

Open jeffbl opened 3 years ago

jeffbl commented 3 years ago

Windows 10 in Virtual machine Chrome browser Extension v.0.0.2

Go to this image on wikipedia:

https://en.wikipedia.org/wiki/Montreal#/media/File:Bas%C3%ADlica_de_Notre-Dame,_Montreal,_Canad%C3%A1,_2017-08-11,_DD_26-28_HDR.jpg

Right click.

Note, popup appears indicating you need to attribute the author:

image

Select "Get IMAGE Rendering"

Wait a long time

Note: Nothing happens.

Right click again

Select "Search Google for Image"

Note: Takes you to search and shows results relevant to the graphic

Expect: If "Search Google for Image" can still get to the content and initiate an action without having to interact with the popup, IMAGE should be able to trigger the server request and show results.

I don't know if this is common beyond Wikipedia, or if it is symptomatic of a broader issue, which would alter the priority.

jeffbl commented 3 years ago

There is more to this. I clicked "View in browser" which brings up the graphic without the popup, and I still don't get any results. So maybe it is actually sending it ok, and just not returning results? Note that resolving #20, and maybe #51 #39 would help with debugging this kind of thing.

Note that it doesn't seem to be a general server crash or anything, since if I go to other graphics on other sites that worked before, they still work.

I'm leaving the original description since I no long know what the problem might be, but I'm assigning to ML team to see if it is a problem on the server in the preprocessor or something (in which case this issue should be moved to the server repo).

jeffbl commented 3 years ago

If I right click the thumbnail version of the image directly from the main page (en.wikipedia.org/wiki/Montreal, about halfway down), it works fine (although the objects it finds are pretty dicey - this is not a hotel, and I don't see a boat as a significant object anywhere? And where is the clock?)

gp1702 commented 3 years ago

I am not sure either, so adding @JRegimbal to this.

JRegimbal commented 3 years ago

Looks like Wikipedia is adding a context menu over it. It should still be possible to use the keyboard to access it. If not, we may need to re-add the tabindex=0 attribute when the DOM changes (which is less than ideal but so is HTML/CSS/JS).