search

SharedStake / Contracts

A repository to track and open source SharedStake's on-chain contracts and their addresses.
10 stars 4 forks source link

Audit changes #11

Closed 0knxwledge closed 3 years ago

0knxwledge commented 3 years ago

I have completed all but 2 of the changes for #10

The 2 remaining changes may need some discussion on how to resolve.

  1. MIN-01M: The donate() function directly updates the state of the contract, namely the curValidatorShares state variable, yet it publicly accessible and does not restrict the input values.
  2. VET-01M: The minters of the system can arbitrarily burn tokens.

vEth2 contract is not upgradeable so this may not be able to be changed.