chore: migration from window.web3 to window.ethereum and a bug fix

SharedStake / SharedStake-ui

SharedStake User Interface using vue.js

https://www.sharedstake.org/

GNU General Public License v3.0

16 stars 16 forks source link

chore: migration from window.web3 to window.ethereum and a bug fix #163

Closed WJakub closed 1 year ago

WJakub commented 1 year ago

Fix default to sgETH on stake pages https://github.com/SharedStake/SharedStake-ui/issues/161
When investigating Firefox not working issue, I realised that metamask no longer supports use of window.web3 and instead asks to use window.ethereum for interactions. We were still using window.web3. I migrated all calls to use the new provider API as per their guide: https://docs.metamask.io/wallet/how-to/migrate-api/

I wasn't able to replicate Firefox issue initially, so would be good if someone who experienced it could test again once this is merged in.

mystic-mango commented 1 year ago

Looks like we are still seeing errors in regards to windows.etherium here?

Console logs from landing page Chrome vs Firefox: https://pr-146.df86yn386iuh7.amplifyapp.com/

Chrome: Screenshot 2023-07-19 at 16 59 43

Firefox: Screenshot 2023-07-19 at 17 00 36

Console logs from stake page Chrome vs Firefox: https://pr-146.df86yn386iuh7.amplifyapp.com/stake Chrome: Screenshot 2023-07-19 at 17 02 25

Firefox: Screenshot 2023-07-19 at 17 01 45

mystic-mango commented 1 year ago

I will try resolve package issues soon, followed by debugging the wallet connections and adding some error states... hopefully this will clear up any errors