Closed nilsreichardt closed 2 weeks ago
Visit the preview URL for this PR (updated for commit fdcff7a):
https://sharezone-website-dev--pr1647-add-teachers-to-the-6zmr4ans.web.app
(expires Wed, 12 Jun 2024 13:57:24 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e
Visit the preview URL for this PR (updated for commit fdcff7a):
https://sharezone-console-dev--pr1647-add-teachers-to-the-pm38kcvg.web.app
(expires Wed, 12 Jun 2024 13:57:08 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6
Visit the preview URL for this PR (updated for commit fdcff7a):
https://sharezone-test--pr1647-add-teachers-to-the-rndh33ec.web.app
(expires Wed, 12 Jun 2024 13:58:30 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b
Very nice! LGTM
Demo
https://github.com/SharezoneApp/sharezone-app/assets/24459435/f9b89af0-f914-4ad5-abca-ff6e1d927745
Summary
A user can add substitution teachers. Free users can see the teachers now. Substitutions are a list on the client now.
Description
This PR adds the option to add substitution teachers.
I changed that now free users can also see the teachers. Reason for this: It doesn't really makes sense if a user can see the substitution teacher, but not the normal teacher.
Before this PR, a lesson had only one substitution at the time. Now, a lesson can have multiple substitutions (like room substitution and teacher substitution). This not a breaking change thanks to a robust database design.
Related Tickets
Closes #1628