SharezoneApp / sharezone-app

Sharezone is a collaborative school organization app for iOS, Android, macOS and web with +500,000 downloads. Built with Flutter & Firebase.
https://sharezone.net
European Union Public License 1.2
254 stars 46 forks source link

Sharezone Wrapped #1660

Closed nilsreichardt closed 2 days ago

nilsreichardt commented 2 weeks ago

Description

This PR adds the Sharezone Wrapped feature. It is a test for this year if users want this feature and if it's worth maintaining. Therefore, the code is not the best.

Users can access the page via the settings. The tile on the settings page is behind a feature flag. Therefore, we can disable this tile when the last state has started with the new school year.

Also, users will get a tip card on the dashboard page to view the wrapped.

Demo

image image

https://github.com/SharezoneApp/sharezone-app/assets/24459435/0e23f07c-a708-457a-95a8-366fe5b3962d

Note: I renamed it from Rewrapped to Wrapped because I noticed Spotify calls it Wrapped: https://pr-newsroom-wp.appspot.com/2023-wrapped/

Closes #1605

github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit 6bf5919):

https://sharezone-test--pr1660-sharezone-rewrapped-94q7hx7k.web.app

(expires Sat, 29 Jun 2024 21:04:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

Sharezone-Admin commented 5 days ago

⬇️ Builds generated by Codemagic for commit 6bf59194f874e3e223ca8db36db9fa6922561803 ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
iOS QR code
Download link
Android QR code
Download link

(expires Fri, 26 Jul 2024 21:13:03 GMT)
Codemagic build: 667c816cbe6a54b07c752329; comment generated with Codemagic App Preview

Jonas-Sander commented 5 days ago

Just some notes before reviewing it fully:

If e.g. "Prüfungen" is 0 there is still the "1.", "2.", "3." subject list which doesn't really makes sense

I fear that if not all exams are added to Sharezone and the number of it is really off, then people might have some slight bias against posting a screenshot as to not have questions about the wrong number of exams. Thats of course just my imagination, might be completely different in reality. I'm also not sure what would be the best way to fix that. Maybe being able to hide the stat? But might be too much hassle for this first MVP version of wrapped or it might be non-obvious too the user. Or the problem doesn't really exist, idk... 🤷‍♂️

Ideally I would like a small hint that explains that the hours of lessons is based on the current lesson plan, we can skip that though. Also not sure if it would look good.