Consider holidays for next schoolday

SharezoneApp / sharezone-app

Sharezone is a collaborative school organization app for iOS, Android, macOS and web with +500,000 downloads. Built with Flutter & Firebase.

https://sharezone.net

European Union Public License 1.2

254 stars 46 forks source link

Consider holidays for next schoolday #1678

Open ImGxrke opened 4 days ago

ImGxrke commented 4 days ago

Fixes #1179

CLAassistant commented 4 days ago

All committers have signed the CLA.

github-actions[bot] commented 2 days ago

Visit the preview URL for this PR (updated for commit c1ae101):

https://sharezone-test--pr1678-consider-holidays-fo-yx7c773n.web.app

_{(expires Fri, 05 Jul 2024 11:14:16 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}

Jonas-Sander commented 2 days ago

Hey, thanks! :) My development environment is currently kinda broken, I'll try to review it in the next few days.

Several tests are currently failing with the following error: Exception: A BlocProvider ancestor with Type BlocProvider<HolidayBloc> should be given in the widget tree. This means that in the setup code for the widget tests you'll need to add a BlocProvider<HolidayBloc> to the widget tree in the test file homework_dialog_test.dart line 281. There are other failing unit tests as well though.

ImGxrke commented 2 days ago

The test are now fixed, however I am not sure if the implementation of the BlocProvider<HolidayBloc> is done in the right way.