ShariqMush / react-native-fullscreenvideo-player

A video player for React Native with controls
14 stars 34 forks source link

can't read property 'showFullscreen' of undefined #1

Closed patricktresp closed 7 years ago

patricktresp commented 7 years ago

Hi i am getting an error using this repo when using the fullscreen button on Android only.

Pause and mute Buttons work properly, but the fullscreen button fires an exception.

I am using react-native-cli: 2.0.1 react-native: 0.48.3

is there a hint you can give me? The error seems to get fired because of this line

NativeModules.BridgeModule.showFullscreen(uri); at index.js

How do i get BridgeModule available in NativeModules

09 10 2017 15 18 53player

Thanks!

Patrick

patricktresp commented 7 years ago

ok i found out it had to to with BridgePackage.java. which was not in correct folder. Not the app Crashes everytime the fullscreen button is hit. When trying to compile this causes a build error @Override public List<Class<? extends JavaScriptModule>> createJSModules() { return Collections.emptyList(); }

with this

android/app/src/main/java/BridgePackage.java:17: error: method does not override or implement a method from a supertype @Override

so i uncommented @Override which offers compiling, but forces the app to crash without any log. ( fatal crash )

The example causes the same error ...

patricktresp commented 7 years ago

i am closing this issue due to title - opening a new one…

MP-OT commented 2 years ago

Hello,

I am having the same issue. Any update about it?

Thanks!