SharkCagey / SharkCage

1 stars 3 forks source link

Test the implementation for security vulnerabilities #29

Open langweg opened 6 years ago

langweg commented 6 years ago

The implementation should be tested for security vulnerabilities by providing attack samples, e.g.

Once this issue is addressed, it makes sense to create sub-issues dealing with individual attacks.

SailReal commented 6 years ago

We looked at the individual points with the following results:

  1. not enough knowledge for the remaining time to implement
  2. not enough knowledge for the remaining time to implement
  3. ACL of config are set to only allow admin access -> modifying is not possible
  4. not enough knowledge for the remaining time to implement
  5. not enough knowledge for the remaining time to implement
  6. all files sent to the service are parsed as config files, if this fails we exit & should be prevented by peters token
  7. windows messages can only be sent to processes on the same desktop -> labeler runs on the secure desktop and is the only process which has a custom message loop
  8. not sure how this can be achieved from the default desktop
  9. is possible, but not preventable

Maybe that would be a good side topic.

bencikpeter commented 6 years ago
  1. Isn´t the picture there for exactly this reason?
langweg commented 6 years ago

Yes, the picture should be available only to the cage labeller. The attack program could try to read the picture from the config file (and fail) and could try to show the wrong picture. The point here is that the attack program could be used in an experiment where unsuspecting users could be observed whether or not they detect that the wrong picture is shown (or if they do not care):