SharkCagey / SharkCage

1 stars 3 forks source link

Log event to system eventlog when switching desktops #62

Open DonatJR opened 6 years ago

DonatJR commented 6 years ago

logging of service install / uninstall is already done by the installer / system

DonatJR commented 6 years ago

I'm not sure it is worth it to include event logging just for the switch desktop event. The process of setting up event logging seems to be rather involved, maybe we can wait until we really need it or have identified more events that need to be logged. Some resources:

@SailReal If you agree, I will move this issue to the backlog

SailReal commented 6 years ago

Thanks for figuring out 👍.

I also think we should wait with the implementation until we have more usecases. So I'll put it back in the backlog.

bencikpeter commented 6 years ago

Wouldn´t it be worth it to implement some general logging capability into the app? all those std::cout calls should IMO be replaced with some logger calls.

Maybe some more lightweight logging framework could serve the purpose, because as @DonatJR pointed out, ETW is pretty heavyweight. Maybe something like Log4Cplus?

DonatJR commented 6 years ago

@bencikpeter Yes, having a logging framework would be awesome! There is an issue for it in the backlog (#9). Can you recommend Log4Cplus? I have never used it but if you think it suits the needs for this project I am okay with commiting to it.