search

SharkCagey / SharkCage

1 stars 3 forks source link

Json parsing crash #67

Closed bencikpeter closed 6 years ago

bencikpeter commented 6 years ago

When trying to launch self-built applications through shark cage, the cage configurator assigns null to application name

{
  "application_name": null,

this, however crashes in SharedFuncitons.cpp::ParseStartProcessMessage at line 81

auto application_name = json_config[APPLICATION_NAME_PROPERTY].get<std::string>();

with output:

Could not parse json: Unknown exception
Could not process start process message
DonatJR commented 6 years ago

Riiight, I'm currently getting the name with the FileDescription of the file. If the description is not set the name will be null. Do you agree using the binary name (with / without extension?) would be a suitable fallback?