SharkCagey / SharkCage

1 stars 3 forks source link

Starting caged applications under correct priviliges #72

Closed bencikpeter closed 6 years ago

bencikpeter commented 6 years ago

Resolving #66

Chage summary:

bencikpeter commented 6 years ago

Why so nitpicky all of the sudden? ๐Ÿ˜„ ๐Ÿ˜„ Fixed and merged ๐Ÿ˜‰

DonatJR commented 6 years ago

@bencikpeter I'm always like that, there is no point in doing something only half right ;) just holding back a little for code in your library as I do not want to annoy you too much ๐Ÿ˜‚ thanks for the fix ๐Ÿ‘

bencikpeter commented 6 years ago

@DonatJR well... I was actually thinking about some last refactoring before I move to a completely different part of the project so... throw all your complaints at me ๐Ÿ˜‚ And Iยดll see what can I do ๐Ÿ˜‡

bencikpeter commented 6 years ago

Uhhhh ๐Ÿ˜ฌ Fixed by #80

SailReal commented 6 years ago

Sorry but we have to revert this merge. We didn't actually check if all functionality is still working (just looked at the code, our bad ...). The configs can no longer be selected by the Chooser and starting the Cage does not actually spawn any processes.

bencikpeter commented 6 years ago

Any more data on that? The chooser should not be affected at all by this change, are you sure the problem is here?

SailReal commented 6 years ago

First you can ignore the problem with the chooser, the main issue is that the createProcess fails for some reason. Maybe we can look into the problem with the chooser and you figure out what the problem is with launching the applications?

bencikpeter commented 6 years ago

@SailReal Agreed.

For the createProcess :Actually... it fails only for non-console applications... console ones launch just fine (that was my bad, I tested only on console apps), anything else fails to launch