Closed DonatJR closed 6 years ago
Oh and we have a conflict file "SharkCage/CageChooser/CageChooserForm.cs"
@SailReal
@DonatJR Sorry for a late reply, I somehow overlooked that mention
I had a look at CheckConfigAccessRights
And I have fer remarks
::LocalFree
and ::LocalAlloc
? Documentation states that
The local functions have greater overhead and provide fewer features than other memory management functions. New applications should use the heap functions unless documentation states that a local function should be used.
so I´d assume it´s a better idea to use those?
variable name of access_rights_okay
is a bit misleading if the value is false
. Maybe something along the lines of access_rights_status
would be more appropriate?
from a functional point of view, I don´t see anything wrong with it, it should be fine.
fixes #75
Configurator
andService
now check the access rights of the config file before opening / processing them furtherChooser
is now based on registry entries written by theConfigurator
@bencikpeter Could you take a look at the
CheckConfigAccessRights
function in theCageService
? You have the most experience with the Windows API in this regard https://github.com/SharkCagey/HTWG_shark_cage/pull/85/files#diff-c70ab997f5ee033d6f6d8bd7ca7264b8R243