search

SharkCagey / SharkCage

1 stars 3 forks source link

66 Starting caged applications under correct privileges #91

Closed bencikpeter closed 6 years ago

bencikpeter commented 6 years ago

Finally, (with all the issues fixed) an up to date and functional version of starting caged apps in a context of logged on user

Note: due to starting as the same user as uses of a normal console session, some applications won´t launch if they already have an active instance on a default desktop (so far only encountered for Google Chrome). I suspect that they are not capable of running on two desktops simultaneously, when using identical user profile. This issue did not came up before, because caged applications were started as NT AUTHORITY thus loading a different user profile when in cage.

DonatJR commented 6 years ago

Nice, thanks for resolving the previous problems so quickly! Will review shortly. :)

The issue with multiple instances on more than one desktop existed before (at least for Keepass). We already check for running instances on the default desktop and then show a message to the user to close these instances and try again, so this should not be any problem.

DonatJR commented 6 years ago

@SailReal The issue you are having is most likely because of the missing check against zero I mentioned in one of my comments

DonatJR commented 6 years ago

@bencikpeter Can we merge this? We need it before #95 can be merged.