SharkCagey / SharkCage

1 stars 3 forks source link

Allow Configurator on secure desktop only (release mode) #95

Closed DonatJR closed 6 years ago

DonatJR commented 6 years ago

fixes #55

regarding WIP: @SailReal the CageConfigurator.sconfig file must be copied to the public documents folder on install and the registry needs to have a corresponding entry

!! Only merge this after #91 !!

SailReal commented 6 years ago

regarding WIP: @SailReal the CageConfigurator.sconfig file must be copied to the public documents folder on install and the registry needs to have a corresponding entry

Should be fixed now.

@DonatJR will review your additions in this pr now. Maybe you can check my?

DonatJR commented 6 years ago

@SailReal Regarding your issue with the release mode: Did you copy all necessary files into the 'install folder'? If yes, did you recreate the config with the new release binary of the Configurator?

I think I know why (from the Service):

#ifdef _DEBUG
    return StartCageManager(session_id, filename, user_token);
#else
    if (SharedFunctions::ValidateCertificate(filename))
    {
        return StartCageManager(session_id, filename, user_token);
    }
    else
    {
        std::wostringstream os;
        os << "Failed to validate the integrity of CageManager! Not starting." << std::endl;
        ::OutputDebugString(os.str().c_str());
        return 0;
    }
#endif

In release mode the Manager must be signed ;)

SailReal commented 6 years ago

Did you copy all necessary files into the 'install folder'? If yes, did you recreate the config with the new release binary of the Configurator?

@DonatJR I used the installer to copy all files and also created new configs. Is it working on your device?

SailReal commented 6 years ago

I think I know why (from the Service):

oh nooooo you're right, the CageManager wasn't signed 😅 now it's working like a charm 😍

bencikpeter commented 6 years ago

Shouldn´t there be a default entry in Chooser to launch Configurator? I am a bit confused about how should I start Configurator in Release? I need an entry to launch Configurator, and to create entry I need Configurator? 🤔

DonatJR commented 6 years ago

@bencikpeter The installer creates an entry in the registry. On your dev system you can simple create your on in the registry itself at Computer\HKEY_LOCAL_MACHINE\SOFTWARE(\WOW6432Node)\SharkCage\Configs (REG_SZ, with name and the path to the config file as value) image Or you can use the debug build of the Configurator to create configs and use them with the release build of all the other applications