Verification rewrite - Githubissues

SharkyTheKing / Sharky

Sharky's Cogs. If you have any suggestions or issues, please feel free to add them here.

19 stars 9 forks source link

Verification rewrite #52

Closed madebylydia closed 3 years ago

madebylydia commented 3 years ago

Preda told me that git's description isn't made for being a patch note... So guess what I did? I made a patch note for what I made.

General:

Remove Optional and import humanize_list and pagify.
Use commands.Cog instead of a getattr.
Added super().init().
Changed the config structure so we can add the new functionality.

All commands:

Added commands.Context to ctx argument.
Docstrings and strings: Special message to Sharky The King: DOTS, SHARKY, YOU KNOW WHAT A DOT IS?

verifyset:

Reduce config call.
Now indicate more informations.

verifyset active:

Now check if role (Either autorole/temprole) has been added before activating. Will autodisable if role configuration has been removed.
Config usage: Special message to Sharky The King: YOU KNOW YOU CAN DO THIS SUPER EASILY WITHOUT USING TOO MUCH IFIFIFIF???

verifyset temprole:

Stop getting always "Cleared the role being used" and show the help if there's nothing registered.
discord.AllowedMentions overwrite. In case I nuke Red one day.

verifyset autorole:

A nice place for autorole, time to trash Trusty's autorole cog. You can add, remove, and list roles.

agree:

Added manage_messages check.
Add verify alias. (I want though on this one)
Less config call.
Now just not only remove a role. :smile:
Added status field, to know if user received role(s).

SharkyTheKing commented 3 years ago

So far everything looks good, I'll pull this on my dev bot, do a quick few tests tomorrow and if everything looks good I'll merge.