search

Sharlaan / material-ui-superselectfield

multiselection autocomplete dropdown component for Material-UI
https://sharlaan.github.io/material-ui-superselectfield
MIT License
266 stars 92 forks source link

Implemented popoverClassName (with default props and types) #141

Closed barrymichaeldoyle closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   38.38%   38.38%           
=======================================
  Files           8        8           
  Lines         198      198           
=======================================
  Hits           76       76           
  Misses        122      122
Impacted Files Coverage Δ
src/defaultProps/selectFieldDefaultProps.js 100% <ø> (ø) :arrow_up:
src/SuperSelectField.js 39.16% <ø> (ø) :arrow_up:
src/types/selectFieldTypes.js 4.16% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef35750...95d941d. Read the comment docs.

Sharlaan commented 6 years ago

Almost perfect PR, thanks

Can you add a description in Readme, after noMatchFoundStyle please ? Can you also squash your commits into one with the PR's title, for cleaner history ?

barrymichaeldoyle commented 6 years ago

All done :+1:

Sharlaan commented 6 years ago

Sorry maybe my modified comment crossed your committing, but can you amend your last commit message with feat: add popoverClassName please ?

barrymichaeldoyle commented 6 years ago

Ok cool I think I've done it :1st_place_medal:

Sharlaan commented 6 years ago

That second commit is weird o.O ?
Merge branch 'master' into master

barrymichaeldoyle commented 6 years ago

Yeah, it keeps giving me merge conflicts and then automatically does that to fix it. This is acting strangely...

barrymichaeldoyle commented 6 years ago

Making a new PR since this one just isn't working...