Sharlaan / material-ui-superselectfield

multiselection autocomplete dropdown component for Material-UI
https://sharlaan.github.io/material-ui-superselectfield
MIT License
266 stars 92 forks source link

feat: add popoverClassName #142

Closed barrymichaeldoyle closed 6 years ago

barrymichaeldoyle commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #142 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   38.38%   38.38%           
=======================================
  Files           8        8           
  Lines         198      198           
=======================================
  Hits           76       76           
  Misses        122      122
Impacted Files Coverage Δ
src/defaultProps/selectFieldDefaultProps.js 100% <ø> (ø) :arrow_up:
src/SuperSelectField.js 39.16% <ø> (ø) :arrow_up:
src/types/selectFieldTypes.js 4.16% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef35750...262e574. Read the comment docs.

Sharlaan commented 6 years ago

I went to your forked repo, it seems you made a merge after pushing your local popoverClassName branch ? It is not needed for a PR here.

Try a git reset --hard HEAD~1 to remove the merge commit, then git push --force: this should update the remote popoverClassName branch and then Github should update this PR automatically.

Sharlaan commented 6 years ago

Oooops i forgot something important:

Can you add in your commit:

This will trigger the release CI process after i merge your PR

barrymichaeldoyle commented 6 years ago

Ah right, thanks. Sorry, not really used to contributing, getting better :) I'll comment once I've done those steps.

barrymichaeldoyle commented 6 years ago

Ok... I have no idea how to add "Increment version number @1.8.7" to my commit. And also, the reason that merge commit keeps popping up is because I always click Resolve Conflicts in the checks. So I'm not going to click it now and leave it there and wait for your advice on what to do.

Thanks for your patience.

Sharlaan commented 6 years ago

i committed your changes directly on my dev branch, closing your issue#139

barrymichaeldoyle commented 6 years ago

Ok cool thanks