search

Sharlaan / material-ui-superselectfield

multiselection autocomplete dropdown component for Material-UI
https://sharlaan.github.io/material-ui-superselectfield
MIT License
266 stars 92 forks source link

Don't focus disabled field (highlited label) #155

Closed Tomassito closed 6 years ago

Tomassito commented 6 years ago

As per TODO in FloatingLabel.js:5, the label should change on focus of disabled field.

codecov-io commented 6 years ago

Codecov Report

Merging #155 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   39.79%   39.79%           
=======================================
  Files           7        7           
  Lines         196      196           
=======================================
  Hits           78       78           
  Misses        118      118
Impacted Files Coverage Δ
src/SuperSelectField.js 39.16% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 310b78f...3c11ec5. Read the comment docs.

Sharlaan commented 6 years ago

Good point thanks, i missed this.

I won't merge this PR, but instead i'll integrate your change directly in next release (check dev branch)