search

Sharlaan / material-ui-superselectfield

multiselection autocomplete dropdown component for Material-UI
https://sharlaan.github.io/material-ui-superselectfield
MIT License
266 stars 92 forks source link

material-ui-superselectfield@1.9.8 has incorrect peer dependency react@>= 15 < 16.3 #184

Open barrymichaeldoyle opened 5 years ago

barrymichaeldoyle commented 5 years ago

Why doesn't this package work with React 16.4?

perepelitca commented 5 years ago

Also found an issue with that dependency range. UNSAFE_componentWillReceiveProps was introduced in 16.3 version, so if I use 16.2, that method won't be called and selectedItems won't be updated. I would say peer dependencies or UNSAFE_componentWillReceiveProps should be changed

Sharlaan commented 5 years ago

@barrymichaeldoyle it is exactly for this reason: deprecation of old lifecycle hooks.

In practice tough, i admit i would need some help on how to manage versions and old/new lifecycle hooks,since poeple seem to complain current solution ie :

I'm open to better ideas.