search

Sharlaan / material-ui-superselectfield

multiselection autocomplete dropdown component for Material-UI
https://sharlaan.github.io/material-ui-superselectfield
MIT License
266 stars 92 forks source link

Allow superselectfield to accept new props for react-infinite #188

Closed perepelitca closed 5 years ago

perepelitca commented 5 years ago

The intention for this pr - is expose additional props for Superselectfield component which will be passed to sub dependency (react-infinite). It is very useful when you have async dropdown and data should be loaded chuck by chunk. Originally Superselectfield doesn't have ability to detect scroll event - when user reaches the bottom of available options. This addition is adding that feature.

Props from react-infinite: https://github.com/seatgeek/react-infinite#number-infiniteloadbeginedgeoffset https://github.com/seatgeek/react-infinite#function-oninfiniteload

codecov-io commented 5 years ago

Codecov Report

Merging #188 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   37.55%   37.55%           
=======================================
  Files           8        8           
  Lines         221      221           
=======================================
  Hits           83       83           
  Misses        138      138
Impacted Files Coverage Δ
src/defaultProps/selectField.defaultProps.js 100% <ø> (ø) :arrow_up:
src/types/selectField.types.js 21.73% <ø> (ø) :arrow_up:
src/SuperSelectField.js 34.04% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 262bd5f...1eed9b9. Read the comment docs.