Sharll-large / FMCL

A Python Minecraft Launcher wants to create a new minecraft launcher developing period for Python developers.
MIT License
16 stars 2 forks source link

更改page的格式 #23

Open mc-124 opened 9 months ago

mc-124 commented 9 months ago

把page的格式改成这样更好

如语言设置页面

def lang_settings(_base: tk.Frame) -> tk.Frame:
    """
        语言设置页面
        :param _base: 父框架
        :return: 语言设置Frame
    """

    def set_lang(_=None) -> None:
        """
            设置语言
            :param _: 无
            :return: 无
        """
        config.change_config_and_safe("language", langs_comb.get())
        langs.lang = langs_comb.get()
        messagebox.showinfo("First Minecraft Launcher", langs["Settings.Lang.Tips.Restart"])

    base = tk.Frame(_base, width=340, background="#E3F3EE")
    langs_comb = ttk.Combobox(base, width=40, values=langs.get_langs(), foreground="#595959",
                              font=("微软雅黑 Light", 10),
                              state="readonly")
    langs_comb.bind("<<ComboboxSelected>>", set_lang)
    langs_comb.current(langs.get_langs().index(config.get("language")))
    langs_comb.pack()
    return base

改成这样

class LangSettings(tk.Frame):
    "语言设置页面"
    def __init__(self, master) -> None:
        """
            :master: 父框架
        """
        super().__init__(master)
        self.langs_comb = ttk.Combobox(master, width=40, values=langs.get_langs(), foreground="#595959",
                              font=("微软雅黑 Light", 10),
                              state="readonly")
        self.langs_comb.bind("<<ComboboxSelected>>", self.set_lang)
        self.langs_comb.current(langs.get_langs().index(config.get("language")))
        self.langs_comb.pack()

    def set_lang(self, _=None) -> None:
        """
            设置语言
            :param _: 无
            :return: 无
        """
        config.change_config_and_safe("language", self.langs_comb.get())
        langs.lang = self.langs_comb.get()
        messagebox.showinfo("First Minecraft Launcher", langs["Settings.Lang.Tips.Restart"])
pxinz commented 8 months ago

也行 这样更规范些

pxinz commented 8 months ago

我提醒下sharll @Sharll-large

Sharll-large commented 8 months ago

我觉得行

mc-124 commented 8 months ago

我觉得行

现在你多了个同语言、同Ui的竞争对手 https://github.com/mc-124/Simple-Craft-Launcher