SharlynLui / pe

0 stars 0 forks source link

App will crash after listing all the results. #10

Open SharlynLui opened 5 months ago

SharlynLui commented 5 months ago

image.png The app crashed and exited after "results details 2"

nus-se-bot commented 5 months ago

Team's Response

Thanks for pointing this out. Through many attempts to reproduce the issue, we found out that the Storage class incorrectly initiates all the classes associated to the user results.

Duplicate as the essence of the reported bug is out of bounds array when displaying results, which can only be reproduced when exiting the game and resuming mid-way.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Index out of bound at the end of results

image.png

Text at the end of results shows "index out of bounds". Can consider reviewing code to not print outside of bound.


[original: nus-cs2113-AY2324S2/pe-interim#1241] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out. Through many attempts to reproduce the issue, we found out that the Storage class incorrectly initiates all the classes associated to the user results.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This bug should not be a duplicate of the original bug because they are not of the same severity even though I agree that solving this bigger bug might also solve the original bug.

The original bug focused on the extra output from the app before the app crashed on me while I continued to test the app. This current bug focuses on the bug causing the app to crash.

Given the explanation of why the bug is of medium severity below, it should not be considered a duplicate to avoid inheriting the same severity.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/SharlynLui/pe/main/files/182075b0-795d-413e-96ef-0af4c0c1bbda.png) **Why is it not low:** It is a flaw that affects the **normal** operation of the product as "exiting the game and resuming mid-way" is a valid operation of the product as seen from the UG. Thus, it is also not very rare as it is likely that users will use the app's stated features. ![image.png](https://raw.githubusercontent.com/SharlynLui/pe/main/files/9cfa59ca-62c8-4d37-ae8b-43582a4964a8.png) **Why it is medium:** This causes occasional inconvenience to users who try to exit the app midway and try to resume their progress after. The app crashing shows that it is unable to handle the bug gracefully.