SharlynLui / pe

0 stars 0 forks source link

Help command #2

Open SharlynLui opened 5 months ago

SharlynLui commented 5 months ago

image.png

The help in CLI showed that one command includes help [command] and should be able to check one, but when input help + commmand, it is considered a invalid command. Thus, the function is not delivered as promised :(

nus-pe-script commented 5 months ago

Team's Response

Thanks for pointing out this issue. We should had implemented a parser to process the second param for help [COMMAND]

As the core gameplay feature still runs as intended (including help without any commands) and no inconvenience is caused to the user, we shall accept this as a FunctionalityBug of severity.Low as per textbook's guidelines below:

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inaccurate help guide

Screenshot 2024-04-19 at 4.23.23 PM.png

When keying in help, guide shows help [command] is a legal command

Help [command] returns an error.


[original: nus-cs2113-AY2324S2/pe-interim#1952] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The bug pointed out is a clear functionality bug as "legitimate user behavior is not handled" as promised by the app. ![image.png](https://raw.githubusercontent.com/SharlynLui/pe/main/files/fde2a689-4efb-435b-a9a4-cda9f54c6d31.png) It should be of medium severity and not low as it fulfills the criteria for medium. It causes occasional inconvenience to users trying to use the feature promised to check an individual command. However, the command is invalid / not implemented. The user can continue to use the rest of the features in the app and not unusable for most users (high) thus it fits well in the medium severity. It is not of low severity as it **does** affect the normal operation of the help function promised in the app. It also does not only appear in very rare situations as it is also easily noticed by other testers and any user who uses "help" and tries to check on the details of one specific command. ![image.png](https://raw.githubusercontent.com/SharlynLui/pe/main/files/6b546605-f3e9-4fbb-8622-51042af3bec5.png) In conclusion, this is an entire promised command under `help` not implemented as seen from the usage `help , help [command]` and should not be downgraded to of low severity. ![image.png](https://raw.githubusercontent.com/SharlynLui/pe/main/files/6c80786c-0f82-484b-83d4-4ae793d27a3a.png)