search

SharonBrizinov / s3viewer

Storage Explorer - Publicly open storage viewer (Amazon S3 Bucket, Azure Blob, FTP server, HTTP Index Of/)
MIT License
432 stars 45 forks source link

Fixed Code Quality Issues #6

Closed HarshCasper closed 3 years ago

HarshCasper commented 3 years ago

Description

Summary:

I ran a DeepSource Analysis on my fork of this repository. You can see all the issues raised by DeepSource here.

DeepSource helps you to automatically find and fix issues in your code during code reviews. This tool looks for anti-patterns, bug risks, performance problems, and raises issues. There are plenty of other issues in relation to Bug Discovery and Anti-Patterns which you would be interested to take a look at.

If you do not want to use DeepSource to continuously analyze this repo, I'll remove the .deepsource.toml from this PR and you can merge the rest of the fixes. If you want to setup DeepSource for Continuous Analysis, I can help you set that up.

HarshCasper commented 3 years ago

Hi @SharonBrizinov

Can you please have a look at this PR? The Travis Build has succeeded, so I guess the PR is ready to be reviewed.

SharonBrizinov commented 3 years ago

Hi,

Thanks for the PR. These changes are breaking the functionality of the functions/classes (changed class functions to static) so I'm closing this PR.