search

SharpScratchMod / Sharp

Sharp Scratch Mod - In Development!
http://sharpscratchmod.github.io
GNU General Public License v2.0
7 stars 2 forks source link

Moving custom reporters/booleans from sprite to sprite #19

Closed Mrcomputer1 closed 7 years ago

Mrcomputer1 commented 7 years ago

sharpglitch1

When you move a reporter or boolean to another sprite the define hat will change from a hat to a reporter or boolean. It will still report but you can't attach any new blocks. If you disconnect any blocks you can't reattach them.

Note: The report block doesn't affect the glitch.

ghost commented 7 years ago

Hmm, can we get @NoMod-Programming here?

Mrcomputer1 commented 7 years ago

@NoMod-Programming @SharpScratchMod/developers

NoMod-Programming commented 7 years ago

This would be the culprit: https://github.com/SharpScratchMod/Sharp/blob/master/src/blocks/Block.as#L579 Simply replace procedureType ? procedureType : type with type. I don't know why I wrote that line like I did, but that should fix it.

ghost commented 7 years ago

Ah, okay Thanks :)

ghost commented 7 years ago

Has this been tested?

Mrcomputer1 commented 7 years ago

@algmwc5 Yes

ghost commented 7 years ago

Okay

Mrcomputer1 commented 7 years ago

Thanks @NoMod-Programming

The only problem with it is that custom reporter's outline of the block stops being an outline when moved to another sprite/to the stage. This does not seem to happen to normal custom blocks and booleans.

sharpglitch2

I will create an issue for it (#20) but since it is very minor and doesn't affect the custom reporter it doesn't need to be fixed.