Fix db type translations for sql server dialect

[williamthiago]

Hey @andrecarlucci,

Reviewing the sql server dialect, I found a mistake on lines #L188 and #L192. The max value of precision for NCHAR and NVARCHAR is 4000.

I also configured the other types according to:

• https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql/linq/sql-clr-type-mapping
• https://docs.microsoft.com/en-us/sql/t-sql/data-types/data-types-transact-sql

Related, are you still using sharpmigrations?

[andrecarlucci]

Hi @williamthiago ,

I changed these mappings so many times that I would like to do it slowly for now on. Here is what we have today:

https://github.com/SharpTools/sharpdata/wiki/DbTypes-x-SqlServer

Please, create "one issue per change" of type justifying it and we could collaboratively talk about it. Thanks!

And yes, we use it in all our products :)

[beppler]

Hi, pull request #19 resolved this issue.