SharpTools / sharpdata

An awesome ORM for querying and modifying databases
MIT License
11 stars 6 forks source link

Remove some invalid SQL Server types and correct others #5

Closed beppler closed 6 years ago

beppler commented 6 years ago

Some types returned on SQLServer dialect did not exist and others could be optimized, but will be only compatible with SQL Server 2008 or newer.

The biggest difference are:

For types that are not supported the error message explains that it could be because of type and precision.

andrecarlucci commented 6 years ago

Hi @beppler ,

I changed these mappings so many times that I would like to do it slowly for now on. Here is what we have today:

https://github.com/SharpTools/sharpdata/wiki/DbTypes-x-SqlServer

Please, create "one issue per change" of type justifying it and we could collaboratively talk about it. Thanks!

beppler commented 6 years ago

Ok, I will close this pull request and then I will open the issues, one for each type. The types that I used are based on SQL Server Data Type Mappings from Microsoft.

beppler commented 6 years ago

Issues #8, #9, #10, #11, #12, #13 and #14 opened.

So I´m closing this pull request.