search

SharpWoW / BodyguardHealth

A WoW AddOn that displays current bodyguard health and status in a frame.
MIT License
0 stars 0 forks source link

Certain non-bodyguard gossips are suppressed #7

Closed b-morgan closed 9 years ago

b-morgan commented 9 years ago

The Pilgrim's Shrines in Shadowmoon Valley give one of four buffs selected on a gossip frame. With BodyguardHealth enabled, the gossip frame is suppressed. This is true for both toons with and toons without a bodyguard.

Sharparam commented 9 years ago

Hm, noticed this with the shaman stone the other day. It's a weird issue since it should only close the gossip if a bodyguard is targeted. Will have to investigate this.

Sharparam commented 9 years ago

@b-morgan for debug, can you run this line:

/run LibStub("LibBodyguard-1.0"):RegisterCallback("gossip_opened", function(l)print(tostring(UnitName("target")),tostring(l:GetInfo().name))end)

And tell me what it prints when you right click the shrine.

I have a suspicion this might happen when bodyguard.name is null, therefore passing the check for target in GOSSIP_SHOW.

Edit: And also, does this issue occur when you have something (that is not a bodyguard) targeted when interacting with the shrine.

Sharparam commented 9 years ago

I pushed v1.3.2-beta to WoWAce just now, try that version and see if the issue persists :)

(Set Preferred release type: Beta in Curse client)

b-morgan commented 9 years ago

With 1.3.1 (on a toon without a bodyguard), the answer to your request is "nil nil" with nothing targeted. With another target, there is no print and the gossip frame for the shrine shows.

With 1.3.2-beta, the shrine gossip appears with or without a target. I'll reply again if a toon with a bodyguard shows any weirdness.

b-morgan commented 9 years ago

Adam,

A couple of “addon management” suggestions. Add a pointer to the GitHub project on the Overview page on WowAce (which will be copied to Curse). I believe you can turn off the WowAce tickets tab. If so, then also add some text to the overview page about where to enter tickets.

You can close (mark as fixed) my ticket on WowAce since it got moved to GitHub and got fixed.

Keep up the good work! As an addon author myself (Skillet and other lesser knowns), I understand the need to minimize the number of places you have to look for input.

Brad

From: Adam Hellberg [mailto:notifications@github.com] Sent: Monday, December 22, 2014 8:08 PM To: SharpWoW/BodyguardHealth Cc: b-morgan Subject: Re: [BodyguardHealth] Certain non-bodyguard gossips are suppressed (#7)

I pushed v1.3.2-beta to WoWAce just now, try that version and see if the issue persists :)

(Set Preferred release type: Beta in Curse client)

— Reply to this email directly or view it on GitHub https://github.com/SharpWoW/BodyguardHealth/issues/7#issuecomment-67917827 .

Sharparam commented 9 years ago

GitHub link should be added indeed (I have on most of my other AddOns, just have neglected it here for whatever reason).

As for moving all ticket management to GitHub, it would be nice to do, but I'm not sure if it might deter some people if they have to create a GitHub account and can't do tickets right from the client or WoWAce.

b-morgan commented 9 years ago

Good point about needing to create another account. Does a Curse account allow you to open tickets on WowAce? I have accounts everywhere (thank goodness for LastPass) so I can’t tell.

For WowAce tickets, keep an eye on them. If people go to add a ticket, they shouldn’t see a bunch of old tickets that make it appear that tickets aren’t being checked.

Brad

From: Adam Hellberg [mailto:notifications@github.com] Sent: Tuesday, December 23, 2014 12:50 PM To: SharpWoW/BodyguardHealth Cc: b-morgan Subject: Re: [BodyguardHealth] Certain non-bodyguard gossips are suppressed (#7)

GitHub link should be added indeed (I have on most of my other AddOns, just have neglected it here for whatever reason).

As for moving all ticket management to GitHub, it would be nice to do, but I'm not sure if it might deter some people if they have to create a GitHub account and can't do tickets right from the client or WoWAce.

— Reply to this email directly or view it on GitHub https://github.com/SharpWoW/BodyguardHealth/issues/7#issuecomment-67991160 .

Sharparam commented 9 years ago

I turned on notifications for tickets et.c after the first missed ticket :P (They should really make you auto-subscribe to addons you manage).

And since WowAce is linked to Curse for a long time now, having a Curse account means you have a WowAce account (and you can always create the ticket through client anyway, though from what I've heard the people who create tickets that way rarely follow up with more details).

Sharparam commented 9 years ago

Closing this issue as I haven't experienced any bugged gossips after fix. Feel free to re-open if there are still issues :)