Add more chocobo themes

Webberjo commented 2 years ago

Added chocobo themes from Final Fantasy 2, 3, 5, 6, 7, 8, 9, 10 and 14.

Description

Downloaded theme rips off YouTube, imported them into Audacity, clipped them and exported as oggs. When seamless looping wasn't possible, used fade out at end of audio after second loop.

Motivation and Context

Four songs isn't enough for an avid chocobo lover. We need more. More!

How Has This Been Tested?

Logged into WoW TBC Classic, opened Interface, selected Addons -> Chocobo, clicked Reset under Song Files. Turned music up. Mounted hawkstrider, dismounted hawkstrider.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have tested my changes in-game.
- [ ] In Retail WoW.
- [ ] In Classic WoW.
- [X] In Burning Crusade Classic WoW.

Sharparam commented 2 years ago

My only concern with adding more songs is that it could increase the risk of a DMCA or similar from Square Enix (something similar happened to one of those soundtrack addons in the past if I'm not mistaken).

I approve of the idea of adding more songs, but I'm not sure how it'd work out in the legal sense. Needs a bit of thinking perhaps. Is it more "robust" to keep song files in a separate addon for download? (That could make discovery harder though)

Webberjo commented 2 years ago

Would it be safer to move the music from the repo to a server and add a button in the addon interface to download them?

Sharparam commented 2 years ago

AddOns can't perform any file operations in the game, and no communication with external services. So it's not possible to integrate it that way, unfortunately.

There's also the AddOn size which grows a lot with the new songs. This could be another reason to break it into a separate AddOn for download.

I might merge this PR later but hold off on a release for now, while thinking about what might be the best way to go about it. This way the files will be in the repo and can be moved to that other AddOn if that's the path that ends up being the way forward.

SharpWoW / Chocobo