search

SharpeRAD / Cake.IIS

IIS addin for Cake
http://cakebuild.net
MIT License
52 stars 28 forks source link

Code cleanups #30

Closed Roemer closed 7 years ago

Roemer commented 7 years ago

Just some various code cleanups to make the code more maintainable. Fixes #29

Roemer commented 7 years ago

Oh and it's all just cosmetics and fully backward compatible.

SharpeRAD commented 7 years ago

I respect your right as an individual to format code any way you want in your own projects but I like regions, so NO...

Roemer commented 7 years ago

The problem is that it is very inconsistent. Some regions are missing, some have wrong "counts" (if i interpret the (x) correctly" and some are plain wrong named. I'm fine to keep them but it should be consistent. What about the other changes?

Roemer commented 7 years ago

Btw it's rather harsh to just close the PR. Making a comment to keep the regions would be fair enough. And give the possibility to adjust it as needed.