search

SharpeRAD / Cake.Powershell

Powershell addin for Cake
http://cakebuild.net
MIT License
83 stars 36 forks source link

Finish Cake 0.29 -> 0.33 transition #76

Closed marcinsmialek closed 5 years ago

marcinsmialek commented 5 years ago

Resolves #75

SharpeRAD commented 5 years ago

Why have you added a dependency on Cake.Core? Does Cake need a dependency to itself when loading an addin?

marcinsmialek commented 5 years ago

My point was that Cake.Powershell depends on and uses Cake.Core 0.33. I wanted to show this explicitly by using NuGet dependencies, so it's not used with the legacy Cake version.

Assuming one always uses Cake 0.33, this change is of little value (and it would be totally ok if you rejected it if you don't think this is useful).

SharpeRAD commented 5 years ago

While I appreciate that Nuget spec recommends adding references to all dependencies, Cake does not. They even created a bot to pick up on this.

marcinsmialek commented 5 years ago

Thanks for clarification