SharpeRAD / Cake.Powershell

Powershell addin for Cake
http://cakebuild.net
MIT License
83 stars 36 forks source link

upgrade to Cake 4 #97

Closed AdaskoTheBeAsT closed 1 month ago

gsgou commented 1 month ago

@SharpeRAD @devlead any chances to get this one merged? @AdaskoTheBeAsT do you have a nuget of the fork available for sharing?

SharpeRAD commented 1 month ago

Can you fix the build?

AdaskoTheBeAsT commented 1 month ago

hi I will take a look one more time - I had problems with solving build issues

gsgou commented 1 month ago

Tks all of you for your time and effort.

From the logs seems the path passed to ReportUnit is not correct, notice the backslash below:

Results File: C:/projects/cake-powershell/build/results/tests/Cake.Powershell.xml Passed! - Failed: 0, Passed: 12, Skipped: 0, Total: 12, Duration: 4 s - Cake.Powershell.Tests.dll (net6.0) Building report [2024.07.03 00:34:21][Info] The file C:/projects/cake-powershell/build/results/tests\Cake.Powershell.xml contains Unknown test results

Also ReportUnit is no longer maintained since Dec 2018. It is replaced by extentreports-dotnet-cli.

gsgou commented 1 month ago

@AdaskoTheBeAsT, can you try my PR on your fork.

As defined in variables.cake, testResultsDir is a relative path var buildResultDir = "./build/results"; var testResultsDir = buildResultDir + "/tests";

ReportUnit() takes absolute paths. https://github.com/reportunit/reportunit/issues/34

AdaskoTheBeAsT commented 1 month ago

@gsgou for me ReportUnit didn't worked - I changed report generation mechanism to use native xunit html report generation by xslt

gsgou commented 1 month ago

Even better @AdaskoTheBeAsT. Thanks for completing the update!

gsgou commented 1 month ago

@SharpeRAD @devlead checks pass now, can be merged!

gsgou commented 1 month ago

Thank you for the quick merge @SharpeRAD. We ll be waiting for the nuget package to be published.