search

Sharpie / RTikZDevice

A R package for producing graphics output as PGF/TikZ code for use in TeX documents.
31 stars 36 forks source link

Fix vignette builds for R 2.12.0+ #14

Closed Sharpie closed 14 years ago

Sharpie commented 14 years ago

The latest version of the tikzDevice, 0.5.1, was checked against R 2.12.0 while that release of R was in development. This was in order to verify that the the implementation of a stub function for polypath() worked correctly.

The SVN version of R 2.12.0 used in these tests was r52686. When R CMD check is run on 0.5.1 using this version everything passes. However, as shown by:

http://cran.r-project.org/web/checks/check_results_tikzDevice.html

R CMD check produces some pretty gnarly looking errors when compiling the vignette using the latest builds of R 2.12.0 or 2.13.0.

Apparently something happened to R since r52686 that could be causing major issues with our package. Stay tuned.

Sharpie commented 14 years ago

Appears to be due to the hacks used in the vignette to give control over the LaTeX environment used to wrap R output.

Something was changed for the final version of 2.12.0 that requires patchSweave.R to be updated or re-thought.

Fortunately, this only affects the vignette; the rest of the package should work fine.

Sharpie commented 14 years ago

Appears to be fixed by the new patchSweave.R at:

http://gist.github.com/627345

Need to add logic that chooses the right version of makeRweaveLatexCodeRunner to use based on the R version and this will be ready to close.

However, to guard against future changes the hacks used in patchSweave.R should be refined into improvements and submitted for inclusion in R-Core.

Sharpie commented 14 years ago

Fixed by Sharpie/RTikZDevice@5df50d78ea3eb6139a27b9ae0e07d60f8b4915cb