search

SharzyL / pastebin-worker

Pastebin on Cloudflare worker, with friendly CLI usage and rich features
https://shz.al
MIT License
732 stars 223 forks source link

[Feature Request] Support custom url in pb script #34

Closed sainnhe closed 7 months ago

sainnhe commented 7 months ago

Thanks for creating this awesome pastebin!

When I'm using the pb script, I found that the domain is hardcoded:

https://github.com/SharzyL/pastebin-worker/blob/8e7fbf57b5ec31fc73ad5b17edf2e24511b684db/scripts/pb#L1-L3

Is it possible to add an option to allow using custom domain so users can use their own instance? Thanks in advance!

SharzyL commented 7 months ago

Have a look at #35. It looks inconvinient to me to specify the domain each time using the script. So I do not prefer specifying the domain via cmd args. The PR will be merged if you find it OK.

sainnhe commented 7 months ago

It looks inconvinient to me to specify the domain each time using the script.

I agree. IMO the PR looks good. Thank you!