Fixing typings declaration and add example in typescript

Shashank3736 / captcha-canvas

A captcha generator by using skia-canvas.

https://captcha-canvas.js.org

Apache License 2.0

61 stars 11 forks source link

Fixing typings declaration and add example in typescript #21

Closed ikr4-m closed 4 years ago

ikr4-m commented 4 years ago

I was make a bot Discord using TypeScript language, and this typings for package didn't recognize in my Text Editor (i using Visual Studio Code). So, I tried to help fix this package by fixing the existing typing so that a Text Editor like Visual Studio Code can recognize this package well.

lgtm-com[bot] commented 4 years ago

This pull request fixes 3 alerts when merging 279baba3d4dffdad7213a14b875b87a739f79a56 into a35b002a079cbe19454f53160443919f94cf62b5 - view on LGTM.com

fixed alerts:

3 for Ineffective parameter type

lgtm-com[bot] commented 4 years ago

This pull request fixes 3 alerts when merging 06e17d76b8b9c5666b8ee49af00e3870f4ee8766 into a35b002a079cbe19454f53160443919f94cf62b5 - view on LGTM.com

fixed alerts:

3 for Ineffective parameter type

Shashank3736 commented 4 years ago

You tested typings now after these changes

ikr4-m commented 4 years ago

Yeah, i've just test it and it works.

For example, if you highlight some property with your mouse, you'll get some information about what does property use from this library.

Shashank3736 commented 4 years ago

Thx for your contribution in typings/doc.

Shashank3736 commented 4 years ago

@all-contributors please add @skymunn for doc and code

allcontributors[bot] commented 4 years ago

@Shashank3736

I've put up a pull request to add @skymunn! :tada: