search

Shauryan123 / pe

0 stars 0 forks source link

Error message does not match the error for adding invalid email #10

Open Shauryan123 opened 3 months ago

Shauryan123 commented 3 months ago

Error message for adding a person with an invalid email does not correspond to the error. Instead of "email is invalid" we get This courseMate already exists in the contact list. Consider adding a suffix to disambiguate

Screenshot 2024-04-19 at 4.39.31 PM.png

Steps to reproduce:

Command to enter: add shaun too -e johnd@examplasfasfasfs -p 98765432 -t johndoe -s Python -s Java

nus-se-bot commented 2 months ago

Team's Response

Thank you for your bug report. Unfortunately, our team will be rejecting this bug since your entered email is indeed a valid email address.

Apart from the specification in our user guide and product, you may wish to refer to the RFC on email address format: https://tools.ietf.org/html/rfc5322#section-3.4.1. In summary, the domain part of the email does not necessarily have to contain a "dot", which can be seen in email addresses in private networks.

Furthermore, in the case of multiple errors, there is no hard requirement on which error we are returning since users are expected to fix both of them anyways.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with the development team's decision to reject this bug on the basis that the entered email could technically be valid according to RFC specifications. The core issue at hand is not solely the validity of the email format, but rather the appropriateness and accuracy of the error message provided by the application when an error is detected. The specific error message received ("This courseMate already exists in the contact list. Consider adding a suffix to disambiguate") is misleading and does not accurately reflect the nature of the error encountered, which in this case is related to an email address that is unusual and likely unintended by a typical user.

The application's response should guide users more effectively by indicating the specific error with the input. Misleading error messages can cause confusion and inefficiency as users may attempt to resolve a non-existent issue (duplicate contact) rather than the real problem (email format). This constitutes a significant usability issue as it affects the user's ability to correctly and efficiently input data.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I also disagree with the downgrading of the issue's severity from Medium to Low. The severity of an error message that does not accurately reflect the error should be considered more significant, as it directly impacts the user experience and the functionality of the application. Incorrect or misleading feedback can lead users on a futile path trying to correct the wrong problems, thereby wasting time and potentially leading to further errors. This bug affects the fundamental usability of the application and should be addressed with appropriate priority to ensure clarity and efficiency in user interactions, justifying a Medium severity classification.