Shauryan123 / pe

0 stars 0 forks source link

Contacts with different names but same email and phone number are allowed in the app #12

Open Shauryan123 opened 3 months ago

Shauryan123 commented 3 months ago

Contacts with different names but same email and phone number are allowed in the app which does not make sense because an email and a phone number can uniquely identify a person.

Steps to reproduce:

command to enter: add John Doe -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++

add John Doe123 -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++

Screenshot 2024-04-19 at 4.44.21 PM.png

soc-pe-bot commented 2 months ago

Team's Response

Thank you for your suggestion. We agree that phone numbers and emails of courseMates should be unique in most cases, thus duplicate detection in phone numbers and emails will be useful for careless users.

However, since these types of user mistakes are uncommon (typos are unlikely to cause the email / phone number to collide with another courseMate), we're downgrading the severity of the bug to "Low". This also requires extra effort for our team to implement and considering this is not a high priority task, we will mark this bug as not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree with the team's decision to mark this issue as "Not in Scope." The ability to uniquely identify a contact by email and phone number is a fundamental aspect of any contact management system. Allowing multiple contacts with identical emails and phone numbers, but different names, can lead to significant confusion and data integrity issues. This is not a rare edge case but a basic functionality that impacts the core operation of the application. The course website specifies that managing duplicate contacts effectively is essential and should be treated as a feature flaw when not handled correctly. Therefore, it is within scope to expect the application to enforce uniqueness in contact identifiers to prevent user errors and enhance data management practices.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Furthermore, I disagree with the severity of this issue being downgraded to "Low." Allowing contacts with the same email and phone number but different names to coexist in the system can lead to practical problems during operations such as sending emails or messages, where duplicate entries might result in sending multiple instances of the same communication to one person. This can be confusing for users and can degrade the quality of user experience significantly. Such a flaw affects the application's reliability and should be considered of "Medium" severity because it can disrupt the basic functionality of contact management and can potentially lead to operational chaos, especially when managing larger groups or coordinating activities among coursemates.