soc-pe-bot
commented
2 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Contacts with different names but same email and phone number are allowed in the app
Contacts with different names but same email and phone number are allowed in the app which does not make sense because an email and a phone number can uniquely identify a person.
Steps to reproduce:
command to enter: add John Doe -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++
add John Doe123 -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++
[original: nus-cs2103-AY2324S2/pe-interim#5315] [original labels: severity.Medium type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for your suggestion. We agree that phone numbers and emails of courseMates should be unique in most cases, thus duplicate detection in phone numbers and emails will be useful for careless users.
However, since these types of user mistakes are uncommon (typos are unlikely to cause the email / phone number to collide with another courseMate), we're downgrading the severity of the bug to "Low". This also requires extra effort for our team to implement and considering this is not a high priority task, we will mark this bug as not in scope.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: I disagree with the team's decision to mark this issue as a duplicate of the earlier reported issue regarding the creation of multiple contacts with the same email and phone number. While related, this issue specifically concerns the editing functionality of the application, which allows existing contacts to be modified in such a way that they duplicate the contact details of another entry. This represents a distinct vector through which data integrity can be compromised, different from the creation of new contacts. The editing function should have safeguards to prevent the creation of duplicates via modifications, which is a separate concern from initially adding duplicate contacts. Therefore, it is imperative to address this as a unique issue to ensure comprehensive data integrity and user trust in the application's management of contact information.
## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Additionally, the downgrading of the severity for this issue from Medium to Low by the original team response to the related bug does not sufficiently recognize the severity of allowing such edits. The ability to edit a contact to duplicate another's phone and email is a serious concern that directly impacts the application’s core functionality of maintaining unique and accurate user data. This issue should be classified at least as "Medium" severity because it can lead to significant confusion, data errors, and potential misuse scenarios where contact details are incorrectly assigned, leading to communication errors and breaches in personal data management. Such errors not only degrade the user experience but also compromise the integrity and reliability of the application.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** This is a high severity issue as it causes user inconvenience quite a lot of the times as users will be allowed to add duplicate contacts and thus, would get confused as to which contact has the latest updates.
Steps to reprodue: Command to enter: edit bernice yu -e alexyeoh@example.com -p 87438807
Now, both alex yeoh and bernice yu have the same email and same phone number