Shauryan123 / pe

0 stars 0 forks source link

Names with Jr. , Sr. which are common people names are disallowed #14

Open Shauryan123 opened 5 months ago

Shauryan123 commented 5 months ago

Steps to reproduce: Command to enter: add John Doe Jr. -e johnd@example.com -p 98765432 -t johndoe -s Python -s Java

Names with Jr. , Sr. which are common people names are disallowed and thus might be a hassle for some users with those names Screenshot 2024-04-19 at 4.53.22 PM.png

nus-se-script commented 5 months ago

Team's Response

Thank you for your bug report. We're correcting the type of the bug to "Feature Flaw" since the functionality is consistent with what's documented in the in-app messages and user guide, which states only alphanumeric characters and spaces are accepted.

Unfortunately, we would still be rejecting this bug under feature flaw since MatchMate only expects nicknames / short names to be supplied, as stated in Page 7 of the user guide:

Pick a nickname if the name is not fully alphanumeric.

Also, according to the course website, they are only considered as feature flaw bugs only if the input is expected to match the legal name of the person, which is not the case in our product.

Therefore, our team's decision would be mark this bug as not in scope. Hope that clarifies your concerns.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The names with Sr. , Jr. are accepted as legal names in real life. Please refer to 'https://law.stackexchange.com/questions/24705/law-regarding-name-suffixes'. Therefore, this is a functionality bug, as a "legitimate user behaviour is not handled by the app". This is written in the cs2103T website.

I strongly disagree with the development team’s decision to classify this issue as "Not in Scope" and as a mere "Feature Flaw." The exclusion of common suffixes such as "Jr." and "Sr." in names contradicts standard practices in data handling where these suffixes are integral parts of many legal names globally. The application's refusal to accept these as part of names is not just a feature oversight; it is a significant functionality flaw because it prevents users from entering names as they are legally recognized or commonly used, which is a legitimate user behavior.

The functionality of any application dealing with personal data, particularly names, should robustly accommodate all common variations, including legally recognized suffixes. The assertion that our application requires only nicknames or short names and thus should not accept suffixes like "Jr." or "Sr." overlooks the reality of diverse user needs and naming conventions, making it an essential functionality issue rather than a mere preference for input format.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** The classification of this issue as a "Feature Flaw" rather than a "Functionality Bug" also needs re-evaluation. According to the cs2103T website, functionality bugs include scenarios where "a legitimate user behavior is not handled by the app." The inability to process names with "Jr." or "Sr." falls directly under this definition because it is a standard expectation in many contexts to include such suffixes in names. Disallowing them impacts the application’s usability and user satisfaction significantly, as it forces users to modify their or others' legal names just to fit the app’s constraints, which is impractical and counterintuitive.