search

Shauryan123 / pe

0 stars 0 forks source link

Incorrect Error Message for require-skill for groups in case of duplicate skills #17

Open Shauryan123 opened 7 months ago

Shauryan123 commented 7 months ago

Steps to reproduce:

Command to enter: require-skill CS2103T G18 -s C++ -s JAvA

Screenshot 2024-04-19 at 5.04.00 PM.png

Here the group CS21-3T G18 already has Java as its skill, so when the user adds the skill JAvA, an error message of duplicate skill should be shown but we get Group successfully modified, Name: CS2103T G18 2 skill(s) are now required for the group!

soc-se-bot commented 7 months ago

Team's Response

Thank you for your bug report.

Yet, we're unfortunately rejecting this bug since this flaw is documented in our planned enhancements (see item 3 of our planned enhancements in Page 22 of our developer guide).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with the development team's decision to reject this bug on the basis that the flaw is documented in planned enhancements. The fact that it is recognized as an area for future improvement does not negate the current issue's impact on users. The application currently provides misleading feedback by indicating that the group has been successfully modified with new skills, even when one of the skills (Java, in this case) is a duplicate and should not have been added again. This is a clear deviation from expected behavior where a specific error message should inform the user about the duplication to prevent confusion.

The lack of a proper error message in this scenario can lead to significant user confusion. Users may believe they have successfully added a new skill, whereas the system has not made any changes regarding the duplicate entry. This discrepancy between the system feedback and actual system state is a critical issue that directly affects the user's ability to manage group skills effectively.