Shauryan123 / pe

0 stars 0 forks source link

Output message does not change when adding duplicate skills for a person #6

Open Shauryan123 opened 3 months ago

Shauryan123 commented 3 months ago

Steps to reproduce: enter add-skill #1 -s Python -s Java enter add-skill #1 -s Python -s Java

Screenshot 2024-04-19 at 4.24.39 PM.png

As you can see above, the output message does not change upon adding the same skill and therefore the user might get confused as to why the output is showing skill added instead of "skill already exists"

soc-se-bot commented 2 months ago

Team's Response

Thank you for your bug report. The absence of such a message is consistent with the product specification for now so we have corrected the type of bug to "Feature Flaw".

Yet, we're unfortunately rejecting this bug since this flaw is documented in our planned enhancements (see item 6 of our planned enhancements in Page 22 of our developer guide).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I respectfully disagree with the development team's decision to classify the lack of a distinct output message for adding duplicate skills as a "Feature Flaw" and subsequently rejecting this as a valid issue based on its mention in the planned enhancements. While I acknowledge the team's foresight in documenting potential enhancements, the current issue extends beyond mere feature improvement—it pertains to fundamental user experience and interface clarity, which are critical for effective application functionality.

The steps to reproduce clearly demonstrate a scenario where a user attempts to add duplicate skills to a person's profile, with the application failing to provide appropriate feedback (i.e., indicating that the skill already exists). The absence of such feedback can lead to user confusion and potentially incorrect assumptions about the application's state or the success of their intended actions.

This oversight can be classified as a usability bug because it directly affects the user's ability to interact with the application effectively and understand its responses. The current behavior may not only cause frustration but also diminish trust in the application's reliability for managing data accurately. It is essential for users to receive accurate and specific feedback based on their actions to prevent repetitive or erroneous data entry, which this issue currently permits without adequate notification.

Moreover, relegating this issue to a planned enhancement undermines the immediate necessity for clear and intuitive user interactions. It is crucial that the application adheres to principles of good user interface design, which include providing clear and immediate feedback to user actions. Thus, this issue should be addressed promptly rather than deferred, ensuring the application meets standard usability expectations and enhances user satisfaction.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as it is a behaviour is not specified and differs from normal expectations e.g. output message does not match the output. (as per the cs2103T website guidelines)