search

Shauryan123 / pe

0 stars 0 forks source link

Names with s/o not allowed #8

Open Shauryan123 opened 3 months ago

Shauryan123 commented 3 months ago

Names with s/o which is a common practice is not allowed.

steps to reproduce: command to enter: add John Doe s/o John Wick -e johndoe@example.com -p 87654321 -t johndoe -s Leadership -s C++

Screenshot 2024-04-19 at 4.15.13 PM.png

The severity is medium because a lot of users follow this convention

nus-se-script commented 2 months ago

Team's Response

Thank you for your bug report. This is a duplicate bug report of #4208 which you also submitted, so you might wish to refer to the response there.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names with d/o not allowed

Steps to reproduce: Command: add Dazy Yong d/o Bella Yong -e dazyyong@example.com -p 97654321 -t johndoe -s Leadership -s C++

Screenshot 2024-04-19 at 4.16.52 PM.png

[original: nus-cs2103-AY2324S2/pe-interim#5311] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your bug report. We're correcting the type of the bug to "Feature Flaw" since the functionality is consistent with what's documented in the in-app messages and user guide, which states only alphanumeric characters and spaces are accepted.

Unfortunately, we would still be rejecting this bug under feature flaw since MatchMate only expects nicknames / short names to be supplied, as stated in Page 7 of the user guide:

Pick a nickname if the name is not fully alphanumeric.

Also, according to the course website, they are only considered as feature flaw bugs only if the input is expected to match the legal name of the person, which is not the case in our product.

Therefore, our team's decision would be to mark this bug as not in scope while downgrading its severity to "Low" at the same time, since it's not expected to affect many users (especially when considering only nicknames). Hope that clarifies your concerns.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree with the team's decision to mark this issue as a duplicate of the one involving "d/o". While both issues pertain to the use of parental designations in names, "s/o" and "d/o" address different user scenarios and potentially different subsets of the user base. Each convention may be relevant in distinct cultural or social contexts, necessitating individual consideration within the application. Marking this as a duplicate undermines the specific user needs associated with each convention and fails to address the broader issue of inclusivity in handling diverse naming practices. Therefore, each should be evaluated separately to ensure comprehensive functionality.

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I disagree with the decision to classify this issue as NotInScope. The functionality to include "s/o" in names is critical for accurately representing users' legal or preferred names, especially in a multicultural educational environment like NUS. This naming convention is recognized and used in formal and social contexts within Singapore and by international communities. Therefore, supporting this convention is not outside the scope but is essential for ensuring the application's relevance and usability for all intended users, reflecting the diverse naming conventions they may use.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I disagree with the reclassification of this issue from a Functionality Bug to a Feature Flaw. The inability to input names with "s/o" represents a significant lapse in the application's ability to handle legitimate user behavior—namely, the input of culturally and legally relevant naming conventions. This issue directly impacts the core functionality of user data input and management, making it a Functionality Bug. It is crucial for the application to accurately reflect and manage user inputs as expected in their cultural and legal contexts.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I also disagree with the downgrading of the severity level from Medium to Low. The use of "s/o" in names is a common convention, not only among local users but also in various international communities represented within the NUS student body. Excluding this convention can lead to significant inconvenience and potential exclusion of users who wish to enter names as they are legally recognized or commonly used. This oversight affects a considerable portion of the user base, warranting a Medium severity classification due to its impact on usability and user experience.