search

Shaviaditya / DataStructures-Algorithms

A collections of many CP-based or DSA-based Questions that is stored various algorithms and datastructures to increase coding aptitutde. Anybody with a knack for coding can feel free to add more solutions and questions in the respective folders
17 stars 26 forks source link

Documentation Error #10

Open himakhaitan opened 2 years ago

himakhaitan commented 2 years ago

In the Readme git clone link, I think it should be git clone link with a username of the user who forked rather than the base repo.

CyberCitizen01 commented 2 years ago

I think its fine,

git clone <remote-url>

first tries to get the name of the repo from the url, then creates the folder [^1], and then actually downloads the files into the newly created folder. [^1]: Gives an error, if already a folder with such a name exists whereas

git clone <remote-url> .

first checks if the folder you are in is empty or not (gives an error if not empty) and then downloads the files into the directory you are in.

I think @Shaviaditya wanted to imply the former one.

himakhaitan commented 2 years ago

git clone https://github.com/Shaviaditya/DataStructures-Algorithms.git will clone the repo created by @Shaviaditya . If you try to push a commit you will be shown a message similar to Access Denied.

But If I clone through git clone https://github.com/himakhaitan/DataStructures-Algorithms.git (The repo which I forked) I can make the commits and later make a Pull Request.

Reference URL : https://kbroman.org/github_tutorial/pages/fork.html

@CyberCitizen01

CyberCitizen01 commented 2 years ago

Yes I agree @himakhaitan, but before you edited the description of the issue it implied that . at the end of command was necessary (it's not). FYI you can still clone @Shaviaditya's repo and update/add another remote referring to your fork, but I guess readme should be updated anyhow and should reflect the fact that the fork should be cloned.

himakhaitan commented 2 years ago

FYI you can always clone any of the repo and add a remote. That was not the point and if so then still my point remains. You should be updated in the documentation the fact that you have to set remote to the repository you forked. Yeah, it should be updated that the forked should be a clone.

Regarding updation of error, I by mistake used <> and hence those texts were not visible to you. Sorry for the error.