Command execution broken with python 3

ShawnDEvans / smbmap

SMBMap is a handy SMB enumeration tool

GNU General Public License v3.0

1.76k stars 343 forks source link

Command execution broken with python 3 #37

Closed camas closed 4 years ago

camas commented 4 years ago

https://github.com/ShawnDEvans/smbmap/blob/fb4b082b3682317a692765f59fe224e821c44871/smbmap.py#L227

data is a bytes type and can't be appended to a str type

$ python smbmap.py ... -x "whoami"
[+] Finding open SMB ports....
[+] User SMB session established on redacted...
[!] Something went wrong: can only concatenate str (not "bytes") to str

ShawnDEvans commented 4 years ago

Good catch, I'm looking into it

ShawnDEvans commented 4 years ago

I think I squashed the bug, but it wasn't exactly an exhaustive QA process. Let me know if you run into any other issues. Thanks for reporting it!